Hi!
Patches look good so far.
Quoting r. Roland Dreier <[EMAIL PROTECTED]>:
> Subject: [PATCH][6/6] Add mem-free interrupt support
>
> Update interrupt handling code to handle mem-free mode. While we're
> at it, improve the Tavor interrupt handling to avoid an extra MMIO
> read of the event cause register.
>
>
> for (i = 0; i < MTHCA_NUM_EQ; ++i)
> - if (ecr & dev->eq_table.eq[i].ecr_mask)
> - mthca_eq_int(dev, &dev->eq_table.eq[i]);
> + if (ecr & dev->eq_table.eq[i].eqn_mask &&
> + mthca_eq_int(dev, &dev->eq_table.eq[i])) {
> + tavor_set_eq_ci(dev, &dev->eq_table.eq[i],
> + dev->eq_table.eq[i].cons_index);
> + tavor_eq_req_not(dev, dev->eq_table.eq[i].eqn);
> + }
> }
I see we are still scanning all EQs on an interrupt.
I was thinking, shall not we rather use ffs to scan only the bits that
are set?
--
MST - Michael S. Tsirkin
_______________________________________________
openib-general mailing list
[email protected]
http://openib.org/mailman/listinfo/openib-general
To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
