On Fri, Feb 25, 2005 at 12:12:50AM +0200, Michael S. Tsirkin wrote: > Quoting r. Libor Michalek <[EMAIL PROTECTED]>: > > Subject: Re: sdp_kvec.c > > > > On Thu, Feb 24, 2005 at 10:58:34PM +0200, Michael S. Tsirkin wrote: > > > Quoting r. Libor Michalek <[EMAIL PROTECTED]>: > > > > > What do you say to removing the comments after the closing }? > > > > > Its clearly unnecessary (most functions are, or shall be, short enough > > > > > to see where they end), and increases the code footprint. > > > > > For me, they make the detection of the function end harder rather than > > > > > easier, since I am always looking for a sole }. > > > > > > > > OK, I'll stop adding them to new functions, and remove them as I > > > > touch code. If I or anyone else get's ambitious we can strip them > > > > from all the functions. > > > Here's some more - I missed the ones after the structure end. > Note how at least in one case (_sdp_prot) the closing comment said > _pf_family. Which shows that these clean-ups are a good thing.
Thanks, I've applied the patch and checked it in. -Libor _______________________________________________ openib-general mailing list [email protected] http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
