Quoting r. Roland Dreier <[EMAIL PROTECTED]>: > Subject: Re: [openib-general] mr_table.max_mtt_order > > Roland> I thought about this a little. I think that any inline > Roland> function forces someone reading the code to look up what > Roland> it does, no matter how descriptive the name we come up > Roland> with. I think it would be better to use fls() directly. > Roland> I'm already in the habit of using ffs() to compute log_2 > Roland> of powers of two but for some reason I never remember > Roland> fls(). > > Actually, since there's already roundup_pow_of_two() in kernel.h, > let's use that. > > - R. >
I plan to post a patch on Sunday. -- MST - Michael S. Tsirkin _______________________________________________ openib-general mailing list [email protected] http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
