>> > I also see the padding on the last segment of
>> > a multipacket send not cleared (I integrated the part of your patch
>> > relating to the pad calculation).
>>
>> I ran some tests, and didn't see any cases where the padding wasn't zero.
>> The RMPP code doesn't touch the padding itself, and create_send should
>> allocate it zeroed. Are you using an analyzer and seeing that it's not
>> zeroed?
>
>Yes. I stating this from what I see on the IB "wire".
Can you try with this patch?
Signed-off-by: Sean Hefty <[EMAIL PROTECTED]>
Index: core/mad.c
===================================================================
--- core/mad.c (revision 2256)
+++ core/mad.c (working copy)
@@ -796,9 +796,9 @@
buf = kmalloc(sizeof *send_buf + buf_size, gfp_mask);
if (!buf)
return ERR_PTR(-ENOMEM);
+ memset(buf, 0, sizeof *send_buf + buf_size);
send_buf = buf + buf_size;
- memset(send_buf, 0, sizeof *send_buf);
send_buf->mad = buf;
send_buf->sge.addr = dma_map_single(mad_agent->device->dma_device,
_______________________________________________
openib-general mailing list
[email protected]
http://openib.org/mailman/listinfo/openib-general
To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
