Committed in revision 2472.

On Mon, 23 May 2005, Tom Duffy wrote:

tduffy> Signed-off-by: Tom Duffy <[EMAIL PROTECTED]>
tduffy> 
tduffy> Index: linux-kernel-new/dat-provider/dapl_openib_cm.c
tduffy> ===================================================================
tduffy> --- linux-kernel-new/dat-provider/dapl_openib_cm.c      (revision 2462)
tduffy> +++ linux-kernel-new/dat-provider/dapl_openib_cm.c      (working copy)
tduffy> @@ -573,12 +573,14 @@ void dapl_ib_reinit_ep(struct dapl_ep *e
tduffy>  
tduffy>         ia_ptr = ep_ptr->header.owner_ia;
tduffy>  
tduffy> -       //*** What if QP is connected?  Do we need to destroy the cm_id
tduffy> -       //*** here as well, send a DREQ, REJ?  What cm_id state are we 
in?
tduffy> -       //*** we may not care if we just destroy the cm_id
tduffy> -       //*** ib_destroy_cm_id(ep_ptr->cm_handle);
tduffy> -       //*** supporting this call may require setting the cm_handle to
tduffy> -       //*** something like NULL wherever it is destroyed
tduffy> +       /*
tduffy> +        * What if QP is connected?  Do we need to destroy the cm_id
tduffy> +        * here as well, send a DREQ, REJ?  What cm_id state are we in?
tduffy> +        * we may not care if we just destroy the cm_id
tduffy> +        * ib_destroy_cm_id(ep_ptr->cm_handle);
tduffy> +        * supporting this call may require setting the cm_handle to
tduffy> +        * something like NULL wherever it is destroyed
tduffy> +        */
tduffy>  
tduffy>         ib_status = dapl_modify_qp_state_to_reset(ep_ptr->qp_handle);
tduffy>         if (ib_status < 0) {
tduffy> @@ -660,8 +662,10 @@ u32 dapl_ib_setup_conn_listener(struct d
tduffy>   */
tduffy>  u32 dapl_ib_remove_conn_listener(struct dapl_ia *ia_ptr, struct 
dapl_sp *sp_ptr)
tduffy>  {
tduffy> -       //*** This will hang if called from CM thread context...
tduffy> -       //*** Move back to using WQ...
tduffy> +       /*
tduffy> +        * This will hang if called from CM thread context...
tduffy> +        * Move back to using WQ...
tduffy> +        */
tduffy>         if (sp_ptr->cm_srvc_handle != NULL) {
tduffy>                 ib_destroy_cm_id(sp_ptr->cm_srvc_handle);
tduffy>                 sp_ptr->cm_srvc_handle = NULL;
tduffy> 
_______________________________________________
openib-general mailing list
[email protected]
http://openib.org/mailman/listinfo/openib-general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general

Reply via email to