Committed in revision 2514.
On Sun, 29 May 2005, Itamar wrote:
itamar> Hi James,
itamar>
itamar> This patch fix a fatal bug that exist in current lastet bits in kdapl
(svn rev 2507)
itamar> As you can see we need to triger the upcall when dapl_evd_dequeue
return with good status
itamar> and quit the method when dapl_evd_dequeue return with non zero status
which mean queue is empty.
itamar> In the current bits no kdapltest can run even the simple quit test.
itamar>
itamar> Please in the future before you commit changes to the svn run a simple
regression.
itamar> Any way with this patch the code is working again.
itamar>
itamar> fix fatal bug in triger the evd upcall
itamar> Signed-off-by: Itamar Rabenstein <[EMAIL PROTECTED]>
itamar>
itamar> Index: dapl_cno_util.c
itamar> ===================================================================
itamar> --- dapl_cno_util.c (revision 2509)
itamar> +++ dapl_cno_util.c (working copy)
itamar> @@ -115,12 +115,8 @@
itamar>
itamar> for (;;) {
itamar> status = dapl_evd_dequeue((DAT_EVD_HANDLE)evd, &event);
itamar> - if (DAT_SUCCESS == status) {
itamar> - dapl_dbg_log(DAPL_DBG_TYPE_ERR,
itamar> - "dapl_evd_dequeue failed: %x\n",
status);
itamar> + if (DAT_SUCCESS != status)
itamar> return;
itamar> - }
itamar> -
itamar>
cno->cno_upcall.upcall_func(cno->cno_upcall.instance_data,
itamar> &event, FALSE);
itamar> }
itamar> --
itamar> Itamar
itamar>
_______________________________________________
openib-general mailing list
[email protected]
http://openib.org/mailman/listinfo/openib-general
To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general