Sorry about that. Should be fixed now. On Wed, 1 Jun 2005, Itamar Rabenstein wrote:
itamar> Hi James, itamar> itamar> you replied with "Committed in revision 2514." itamar> But I am checking and you have committed my patch with a change. itamar> Please whenever you decide to change a patch please reply with a reason or itamar> at least say that you have change it so other can make a review for it. itamar> itamar> any way why did you change the patch? as I said in my mail a return value itamar> from dapl_evd_dequeue can be itamar> queue empty. I don't think we should print "dapl_evd_dequeue failed" for itamar> empty queue it is a good return value. itamar> itamar> Itamar itamar> itamar> > -----Original Message----- itamar> > From: James Lentini [mailto:[EMAIL PROTECTED] itamar> > Sent: Tuesday, May 31, 2005 6:32 PM itamar> > To: Itamar itamar> > Cc: [EMAIL PROTECTED]; [email protected] itamar> > Subject: Re: [PATCH][kdapl] fix fatal bug in triger the evd upcall itamar> > itamar> > itamar> > itamar> > Committed in revision 2514. itamar> > itamar> > On Sun, 29 May 2005, Itamar wrote: itamar> > itamar> > itamar> Hi James, itamar> > itamar> itamar> > itamar> This patch fix a fatal bug that exist in current itamar> > lastet bits in kdapl (svn rev 2507) itamar> > itamar> As you can see we need to triger the upcall when itamar> > dapl_evd_dequeue return with good status itamar> > itamar> and quit the method when dapl_evd_dequeue return with itamar> > non zero status which mean queue is empty. itamar> > itamar> In the current bits no kdapltest can run even the itamar> > simple quit test. itamar> > itamar> itamar> > itamar> Please in the future before you commit changes to the itamar> > svn run a simple regression. itamar> > itamar> Any way with this patch the code is working again. itamar> > itamar> itamar> > itamar> fix fatal bug in triger the evd upcall itamar> > itamar> Signed-off-by: Itamar Rabenstein <[EMAIL PROTECTED]> itamar> > itamar> itamar> > itamar> Index: dapl_cno_util.c itamar> > itamar> itamar> > =================================================================== itamar> > itamar> --- dapl_cno_util.c (revision 2509) itamar> > itamar> +++ dapl_cno_util.c (working copy) itamar> > itamar> @@ -115,12 +115,8 @@ itamar> > itamar> itamar> > itamar> for (;;) { itamar> > itamar> status = itamar> > dapl_evd_dequeue((DAT_EVD_HANDLE)evd, &event); itamar> > itamar> - if (DAT_SUCCESS == status) { itamar> > itamar> - dapl_dbg_log(DAPL_DBG_TYPE_ERR, itamar> > itamar> - "dapl_evd_dequeue itamar> > failed: %x\n", status); itamar> > itamar> + if (DAT_SUCCESS != status) itamar> > itamar> return; itamar> > itamar> - } itamar> > itamar> - itamar> > itamar> itamar> > cno->cno_upcall.upcall_func(cno->cno_upcall.instance_data, itamar> > itamar> &event, FALSE); itamar> > itamar> } itamar> > itamar> -- itamar> > itamar> Itamar itamar> > itamar> itamar> > itamar> _______________________________________________ openib-general mailing list [email protected] http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
