On 6/8/05, Tom Duffy <[EMAIL PROTECTED]> wrote: > I am putting this out there to see what people think about this sort of > change. This only does it for one of the functions in dat provider, but > I will change it for all if this is accepted. > > Basically, instead of using a redirected function wrapper, it calls the > function directly from the struct (how the rest of the kernel does it). > > And it gets rid of the typedef DAT_IA_QUERY_FUNC. >
Hiding the fact that there was a method table was definitely a cosmetic decision to appeal to the biases of user mode C programmers. I agree that anyone working in the kernel is already quite familiar with calling a function from a struct. A strong argument can be made that a kernel programmer should know that they are making a call through a method table. What I am not following is why you think DAT_IA_QUERY_FUNC is somehow different than all of the other functions in a DAT method table. Is this just a test run? If not, what is the criteria for deciding which methods are exposed and which have their method table underpinnings kept hidden? _______________________________________________ openib-general mailing list [email protected] http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
