On Fri, 10 Jun 2005, Itamar Rabenstein wrote:


Does that sound reasonable?

Ok, I can wait.  I definitely understand the need to stabilize the
provider and not introduce any new bugs.

I will start playing around again with getting rid of dapl's own linked
lists.

-tduffy

Hi All,

James,
can you close the issue of merging files into one file ?
it is hard to create a big patch when you know that the file you are working
on
is going to be deleted or merged with other file.
I think we only left ia and cr

Don't let that block you. If you create a patch and I merge the files, I'll fix your patch so it applies.

I think that sp+psp+rsp should be one file dapl_sp.c

Tom,
dapl has many lists and I think that most of them should be kernel lists.
I think that the following list :
in struct dapl_sp : struct dapl_llist_entry *cr_list_head;      /* CR
pending queue */
should be replaced with kernel rb tree because
we search in this list in the hot path of the connect-disconnect flow.

Do we know that this is a performance bottleneck?

we have agreed in the past that evd ring buffer should be replaced also with
kernel lists.

If you can replace the ring buffer with a data structure provided by Linux, that is a win. Maintaining the locking guarantees will be the hard part.

I will prepare a patch that will remove dapl_hash (no need for this hash).

Itamar


_______________________________________________
openib-general mailing list
[email protected]
http://openib.org/mailman/listinfo/openib-general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general

Reply via email to