[openib-general] [sdp] debug strings

[Bernhard Fischer]

Hi,

Upon loading ib_sdp with debugging enabled, i see:

INIT: : SDP module load.
with attached patchlet, i see the (to me) more appealing string
ib_sdp INIT: SDP module load.



- remove duplicate ': ' and prefix messages from sdp with ib_sdp
  like ib_mthca does.
- fix odd "INIT: : INIT: SDP module unload." debug message.


thank you,

diff -X excl -rduNp 
gen2.2551.oorig/trunk/src/linux-kernel/infiniband/ulp/sdp/sdp_inet.c 
gen2.2551/trunk/src/linux-kernel/infiniband/ulp/sdp/sdp_inet.c
--- gen2.2551.oorig/trunk/src/linux-kernel/infiniband/ulp/sdp/sdp_inet.c        
2005-05-17 07:36:11.000000000 +0000
+++ gen2.2551/trunk/src/linux-kernel/infiniband/ulp/sdp/sdp_inet.c      
2005-06-10 19:07:49.000000000 +0000
@@ -79,7 +79,7 @@ MODULE_PARM_DESC(recv_post_max,
                 "Set the receive completion queue size.");
 
 module_param(recv_buff_max, int, 0);
-MODULE_PARM_DESC(recv_buff_max, 
+MODULE_PARM_DESC(recv_buff_max,
                 "Set the maximum number of receives buffered.");
 
 module_param(send_post_max, int, 0);
@@ -91,7 +91,7 @@ MODULE_PARM_DESC(send_buff_max,
                 "Set the maximum number of sends buffered.");
 
 module_param(send_usig_max, int, 0);
-MODULE_PARM_DESC(send_usig_max, 
+MODULE_PARM_DESC(send_usig_max,
                 "Set the maximum consecutive unsignalled send events.");
 
 module_param(sdp_debug_level, int, 0);
@@ -1571,7 +1571,7 @@ error_proc:
  */
 static void __exit sdp_exit(void)
 {
-       sdp_dbg_init("INIT: SDP module unload.");
+       sdp_dbg_init("SDP module unload.");
        /*
         * unregister
         */
diff -X excl -rduNp 
gen2.2551.oorig/trunk/src/linux-kernel/infiniband/ulp/sdp/sdp_proto.h 
gen2.2551/trunk/src/linux-kernel/infiniband/ulp/sdp/sdp_proto.h
--- gen2.2551.oorig/trunk/src/linux-kernel/infiniband/ulp/sdp/sdp_proto.h       
2005-05-17 07:36:11.000000000 +0000
+++ gen2.2551/trunk/src/linux-kernel/infiniband/ulp/sdp/sdp_proto.h     
2005-06-10 16:26:10.000000000 +0000
@@ -471,7 +471,7 @@ extern int sdp_debug_level;
 #define sdp_dbg_out(level, type, format, arg...) \
         do { \
                 if (!(level > sdp_debug_level)) { \
-                        printk("<%d>%s: " format "\n", \
+                        printk("<%d>ib_sdp %s: " format "\n", \
                                level, type, ## arg);  \
                 } \
         } while (0)
@@ -516,7 +516,7 @@ extern int sdp_debug_level;
 #define sdp_dbg_init(format, arg...) do { } while (0)
 #else
 #define sdp_dbg_init(format, arg...) \
-        sdp_dbg_out(__SDP_DEBUG_INIT, "INIT: ", format, ## arg)
+        sdp_dbg_out(__SDP_DEBUG_INIT, "INIT", format, ## arg)
 #endif
 
 #if __SDP_DEBUG_LEVEL < __SDP_DEBUG_WARN


_______________________________________________
openib-general mailing list
openib-general@openib.org
http://openib.org/mailman/listinfo/openib-general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general