On Tue, 14 Jun 2005, Tom Duffy wrote:
tduffy> On Tue, 2005-06-14 at 16:21 -0400, James Lentini wrote: tduffy> > tduffy> > On Mon, 13 Jun 2005, Tom Duffy wrote: tduffy> > tduffy> > tduffy> diff -Nurp -X /home/tduffy/dontdiff linux-kernel-ll8/dat-provider/dapl_ia.c linux-kernel-ll9/dat-provider/dapl_ia.c tduffy> > tduffy> --- linux-kernel-ll8/dat-provider/dapl_ia.c 2005-06-13 16:50:30.624000000 -0700 tduffy> > tduffy> +++ linux-kernel-ll9/dat-provider/dapl_ia.c 2005-06-13 16:56:10.004000000 -0700 tduffy> > tduffy> @@ -62,7 +62,6 @@ struct dapl_ia *dapl_ia_alloc(struct dat tduffy> > tduffy> ia->hca = hca; tduffy> > tduffy> ia->async_error_evd = NULL; tduffy> > tduffy> ia->cleanup_async_error_evd = FALSE; tduffy> > tduffy> - dapl_llist_init_entry(&ia->hca_ia_list_entry); tduffy> > tduffy> > Shouldn't we replace this line with an INIT_LIST_HEAD(&ia->list)? Or tduffy> > is this going to be done in the next patch? tduffy> tduffy> This isn't the head. It is the entry. Therefore, it doesn't need to be tduffy> initialized. Got it. Then I have an unnecessary INIT_LIST_HEAD on line 236 of dat/dictionary.c. _______________________________________________ openib-general mailing list [email protected] http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
