On Thu, Jun 23, 2005 at 04:55:38PM -0400, James Lentini wrote: > My argument in favor of retaining them is that dapl_evd_wc_to_event() > will crash if the cookie NULL. A BUG_ON will detect this situation > sooner rather than later and therefore make the problem easier to > diagnose. Did I miss something?
The tombstone from the data page fault panic should make this nearly as obvious as the BUG_ON(). Yes, I agree a BUG_ON() is completely obvious. But it's also burning CPU cycles for something that should never happen and debugging is straight forware without the BUG_ON(). (Trust me, I've done more than a few of these on three different architectures). grant _______________________________________________ openib-general mailing list [email protected] http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
