On Wed, Jun 22, 2005 at 05:13:03PM -0400, James Lentini wrote: > > This is an excellent simplification. Committed in revision 2682 with a > few minor modifications: > > - kept printouts in dat_registry_add_provider, > dat_registry_remove_provider, and dat_registry_list_providers > > - updated printout in dat_ia_close (this wasn't something you > changed) > > - removed parens around sizeof
kernel style is to have parants around it, but all of the openib code is different. well, let's keep it that way. > - removed space in front of labels lots of new kernel code uses the space, but again it's okay to stick to the surrounding code. > The last two are for consistency with the coding style we've been > using. If we've deviated from what is acceptable, let us know. > > Given this simplification, I can think of a few more changes: > > - rename api.c to registry.c Note yet. The code will get some major surgery still, and as part of that split into different files again maybe, just on very different boundaries. > - remove all "dictionary" references: rename dat_dictionary_search to > dat_provider_list_search, rename struct dat_dictionary_entry to > struct dat_provider_list_entry, rename > dat_dictionary_key_is_equal() to dat_provider_info_is_equal() I'll plan bigger changes in that area that will kill the dictionary term, so a simple search and replace is probably not worth it. _______________________________________________ openib-general mailing list [email protected] http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
