On Wed, 2005-07-20 at 03:35, Michael S. Tsirkin wrote: > Quoting r. Hal Rosenstock <[EMAIL PROTECTED]>: > > Subject: Re: [PATCHv3] ucm: Only print messages when debug level set > > > > On Tue, 2005-07-19 at 20:14, Libor Michalek wrote: > > > On Wed, Jul 13, 2005 at 07:40:07PM -0400, Hal Rosenstock wrote: > > > > ucm: Only print messages when debug level set > > > > > > I don't think you can assume that ucm_debug_level will always be > > > initialized correctly, or is module_param_named clearing it? Otherwise > > > looks fine... > > > > Same is true for IPoIB so it would need changing in both places if so. > > > > -- Hal > > I always thought that in C global storage is zero-initialized. > What am I missing?
Right: "A static object not explicitly initialized is initialized as if it (or its members) were assigned the constant 0." So this patch is OK to commit (and IPoIB is fine in terms of this). -- Hal _______________________________________________ openib-general mailing list [email protected] http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
