On Tue, 2 Aug 2005, Guy German wrote:

Hi,

James Lentini <mailto:[EMAIL PROTECTED]> wrote:
On Fri, 29 Jul 2005, Guy German wrote:

+       array = (u64 *)phys_addr.for_array; /* need to add for_u64_array
to union */ What does this comment mean?

I think the right way to do it is :
array = phys_addr.for_u64_array
(Givven the union consists of a new type u64* called "for_u64_array")

I believe the original idea was to have IA memory use the
DAT_REGION_DESCRIPTION's for_pointer value.

for_pointer is void*, and: *((void *)array)!=*((u64 *)array) in 32 bit machines

I'd rather update the for_pointer type to be correct (and change the name if necessary) than add a new memmber, for_u64_array, to the union.
_______________________________________________
openib-general mailing list
[email protected]
http://openib.org/mailman/listinfo/openib-general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general

Reply via email to