Quoting r. Tom Duffy <[EMAIL PROTECTED]>: > Subject: Re: [PATCH] SDP: fix oops with port reuse > > > On Aug 16, 2005, at 2:19 AM, Michael S. Tsirkin wrote: > > > This is what I committed. I'm not against making sdp_inet_port_put void, > looking at libsdp this shouldnt introduce any problems, but lets make it > a separate patch. > > I agree that changing it to void should be done separately. But, I thought > that we didn't want to remove the port unless it was really on the list
Right. > and that just checking if the src_port was set wouldn't guarantee this. Why not? You cant really bind to port 0, can you? > Maybe its a good idea to init bind_next at socket creation, at port_put > we could call list_del_init, and/or use list_empty to figure out > whether the socket is on the bind list. > > > Do you mean we would setup the bind_next field to point to itself? Yes. > This is normally reserved for list heads. What's list_del_init for then? -- MST _______________________________________________ openib-general mailing list [email protected] http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
