On Tue, 2005-09-06 at 09:59, Eitan Zahavi wrote: > Good - we needed it long ago. > > Hal Rosenstock wrote: > >> cl_ntoh64(REQUIRED_MC_CREATE_COMP_MASK), > It is common practice to use CL_NTOH (upper case) for converting constants. > The claim in the cl_byteswap.h is that the upper case version of constants is > handled > by the compiler and thus is faster to evaluate. I must say I have not > verified that but > it seems logical to me.
That was a preexisting line of code (and I am sure there are other instances of similar things). I changed it and retested it as you suggest. I will reissue the patch. > Anyway the upper case version should never be used on anything that is not a > constant! I found another MC error message to update too. Patch coming for this too... -- Hal _______________________________________________ openib-general mailing list [email protected] http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
