Michael S. Tsirkin wrote:
The state of the cm_id is controlled by the CM and can change at any time
as a result of processing a received MAD.
I see. Lets hide this field then.
At least, this warrants a comment in the header file.
In ib_cm.h:
enum ib_cm_state state; /* internal CM/debug use */
enum ib_cm_lap_state lap_state; /* internal CM/debug use */
I'd say you cant usefully debug with something that changes at any time, anyway.
Let's just have a compile time flag for dumping cm traffic to syslog.
Makes sense?
I use madeye to dump CM MAD traffic. I can use that to verify that cm_id states
are correct based on which messages have been received. I did try to make these
states internal to the CM a few months ago, but did not want to remove them from
the API until all clients no longer access them. I believe that once SDP is
fixed, these can be moved into the internal structure to avoid this issue in the
future.
- Sean
_______________________________________________
openib-general mailing list
[email protected]
http://openib.org/mailman/listinfo/openib-general
To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
