On Mon, 2005-10-17 at 15:38, Sean Hefty wrote: > Hal Rosenstock wrote: > >>The agent code now allocates a buffer for the MAD by calling > >>ib_create_send_mad(). The input MAD buffer is copied to the send buffer, > >>then > >>transmitted. The result is that the input MAD buffer is always available > >>for > >>posting on the receive queue. > > > > What about the other resources needed ? Are they always available ? > > Not sure what you're referring to here. The changes to mad.c were very minor.
I was referring to the calls in agent_send_response which could fail. > >>IMO, the print statements would be better placed in agent_send_response(), > >>which > >> knows the context surrounding the failure, than by a caller. > > > > That's what I was suggesting (but I didn't see them in your updated > > patch). > > No - I didn't add debug print statements to the code. There were only a > couple > of prints in the original code. Do you want debug prints added? Yes. It can be done as a subsequent patch. I just think we want to know when those calls in agent_send_response do fail as they may explain some other external behavior (e.g. a lack of response by the SMA and/or PMA). -- Hal _______________________________________________ openib-general mailing list [email protected] http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
