Hi Roland,
When do you expect to apply the FMRs patch for SRP?
Thanks,
Tziporet
-----Original Message-----
From: Vu Pham [mailto:[EMAIL PROTECTED]]
Sent: Tuesday, October 11, 2005 8:03 PM
To: Roland Dreier
Cc: [EMAIL PROTECTED]; [email protected]
Subject: [openib-general] Re: [PATCH] SRP: don't use TX IU after freeing
it
Roland,
Thanks or reviewing it.
Responding to your feedback, I prepare new patch (attached)
>
> Why put a pointer to struct list_head here instead of just a struct
> list_head? If you just used the struct, then you wouldn't need this:
>
Done. Using struct list_head instead of pointer
> > + u16 in_use;
> > };
>
> I can't find anywhere that the in_use flag is used.
>
Removed
> > +static int srp_map_fmr(struct srp_target_port *target, struct scatterlist *scat,
> > + int sg_cnt, struct srp_request *req)
>
> [...]
>
> > + return -ENOMEM;
>
> > + } else if (fmr_cnt <= 0) {
>
> fmr_cnt is unsigned so I think this is going to get you in trouble.
> Might as well make fmr_cnt a plain int to make things simpler.
>
In previous patch, fmr_cnt was already declared as int
> Also, it might be good to try and add some more comments explaining
> srp_map_fmr() -- it would definitely help me review.
>
I added some comments - Hope they help your review (instead
of confusing you more :))
Signed-off-by: Vu Pham <[EMAIL PROTECTED]>
_______________________________________________ openib-general mailing list [email protected] http://openib.org/mailman/listinfo/openib-general
To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
