Quoting r. Roland Dreier <[EMAIL PROTECTED]>: > Subject: Re: [PATCH] sdp zero copy support > > I haven't read the code yet, but: > > > +config INFINIBAND_SDP_SEND_ZCOPY > > + bool "Sockets Direct Protocol Zero Copy Send support" > > + depends on INFINIBAND_SDP > > + default y > > + ---help--- > > + This option enables Zero Copy support for send_msg > transactions. > > + > > +config INFINIBAND_SDP_RECV_ZCOPY > > + bool "Sockets Direct Protocol Zero Copy Receive support" > > + depends on INFINIBAND_SDP && INFINIBAND_SDP_SEND_ZCOPY > > + default y > > + ---help--- > > + This option enables Zero Copy support for recv_msg > transactions. > > Why would I ever say 'n'? I think we should either get rid of these > config options, or if there is a reason for them, explain it better in > the help text. > > - R. >
Actually, zero copy still does not use the DMA API, so I should make it dependent on x86/x86_64. I guess this option is also useful for debug purposes. I'll clarify this in the help text. -- MST _______________________________________________ openib-general mailing list [email protected] http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
