On Wed, 2005-11-23 at 02:06, Yael Kalka wrote: > Hi Hal, > You are correct. The Notices are requests. Then the assertion on the > resp_expected > should be removed from the osm_sa_mad_ctrl.c.
Thanks. Applied. > Thanks, > Yael > > -----Original Message----- > From: Hal Rosenstock [mailto:[EMAIL PROTECTED] > Sent: Tuesday, November 22, 2005 3:14 PM > To: Yael Kalka > Cc: [email protected]; Eitan Zahavi > Subject: Re: [PATCH] Opensm - wrong assertions in error callbacks > > > Hi Yael, > > On Tue, 2005-11-22 at 07:19, Yael Kalka wrote: > > Hi Hal, > > > > I saw that in the send_err_callback functions both in osm_sa_mad_ctrl > > and in osm_sm_mad_ctrl are wrong. I assume we haven't encountered > > these problems since we haven't encountered send errors on debug > > mode... > > One question about this below: > > > In osm_sa_mad_ctrl - all mads should be with resp_expected == FALSE > > (and not TRUE), as these are all responses. > > What about SA Notices ? Aren't they requests from the perspective of the > SA ? > > > In osm_sm_mad_ctrl - we can send both requests and responses (for > > SMInfo, for example), so no use in checking the resp_expected flag. > > This patch fixes these issues. > > -- Hal _______________________________________________ openib-general mailing list [email protected] http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
