On Wed, Dec 28, 2005 at 04:31:19PM -0800, Bryan O'Sullivan wrote: > > There are a few requested changes we have chosen to omit for now: > > - The driver still uses EXPORT_SYMBOL, for consistency with other > code in drivers/infiniband
Why would that matter? > - Someone asked for the kernel's i2c infrastructure to be used, but > our i2c usage is very specialised, and it would be more of a mess > to use the kernel's Why is this? What is so messy about the in-kernel i2c interfaces? (yeah, I know that there are some oddities, just want to know what you specifically are not liking...) > - We're still using ioctls instead of sysfs or configfs in some > cases, to maintain userspace compatibility Compatibility with what? The driver isn't in the kernel tree yet, so there's no old kernel versions to remain compatibile with :) I also noticed that you are still using the uint64_t type variable types, can you please switch to the proper kernel types instead (u64 in this specific example.) thanks, greg k-h _______________________________________________ openib-general mailing list [email protected] http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
