On Sun, 2006-01-01 at 03:14, Ofer Gigi wrote: > Hi Hal, > > 1. About the osm_indent - you are correct - it should have been in > another patch.
Thanks. Applied. > 2. Extra spaces - please remove - thanks. Done. > 3. > + /* signal = osm_lid_mgr_process_sm( p_mgr->p_lid_mgr ); */ > > Why add this commented out line ? > > My mistake, I commented the original code and forgot to remove - please > remove it. > 4. > # -i3 Substitute indent with 3 spaces > > # -npcs No space after procedure calls > > # -prs Space after parenthesis > > -# -nsai No space after if keyword > > -# -nsaw No space after while keyword > > +# -nsai No space after if keyword - removed > > +# -nsaw No space after while keyword - removed > > Should these comments just be removed ? > No, please leave them, so people will know what they mean. Thanks. Applied. -- Hal _______________________________________________ openib-general mailing list [email protected] http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
