Sean> I haven't seen anyone object to merging the other changes.
Sean> Roland, Hal - any opinion?
I don't see much urgency in merging it now. When svn diverges from
what's upstream in the kernel, it makes my life harder because I have
to figure out which patches belong upstream and sometimes merge things
by hand (when they hit the divergent regions).
Also I can't say I'm thrilled by adding
> + struct iw_cm_verbs *iwcm;
to struct ib_device -- we still really haven't answered the issue of
how iWARP connections interact with the host network stack, we've just
pushed it off into low-level driver code where we can't see it.
Finally (a minor point), there's a lot of stuff like
> + const void* pdata, u8 pdata_len)
It's more idiomatic in the kernel to say "void *pdata" -- in other
words, the space comes before the *, not after it.
- R.
_______________________________________________
openib-general mailing list
openib-general@openib.org
http://openib.org/mailman/listinfo/openib-general
To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
