Quoting r. Hal Rosenstock <[EMAIL PROTECTED]>:
> >  #define OSM_LOG_EXIT( OSM_LOG_PTR ) \
> >     osm_log( OSM_LOG_PTR, OSM_LOG_FUNCS, \
> > -            "%s: ]\n", osm_log_func_name );
> > +            "%s: ]\n", __func__ )
> >  
> >  /****h* OpenSM/Log
> >  * NAME
> 
> 
> This looks fine for Linux to me but since this file is shared by
> Windows, doesn't it need a conditionalization for those builds ? 
> 
> Also, will __FUNCTION__ work in all the Windows cases ?
> 
> -- Hal
> 

BTW functions that include ';' like OSM_LOG_EXIT here must be wrapped with do {}
while (0), in any case.

-- 
Michael S. Tsirkin
Staff Engineer, Mellanox Technologies
_______________________________________________
openib-general mailing list
[email protected]
http://openib.org/mailman/listinfo/openib-general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general

Reply via email to