Quoting r. Roland Dreier <[EMAIL PROTECTED]>:
> >From reading the code we can't call netif_carrier_on until after
> priv->broadcast has the attached flag set.  In ipoib_mcast_join_task(),
> we have
> 
>       if (!test_bit(IPOIB_MCAST_FLAG_ATTACHED, &priv->broadcast->flags)) {
>               ipoib_mcast_join(dev, priv->broadcast, 0);
>               return;
>       }
> 
> and then at the very bottom
> 
>       netif_carrier_on(dev);
> 
>  - R.
> 

But we set the bit on finish, I thought ipoib_mcast_join only starts
it - right?

-- 
Michael S. Tsirkin
Staff Engineer, Mellanox Technologies
_______________________________________________
openib-general mailing list
[email protected]
http://openib.org/mailman/listinfo/openib-general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general

Reply via email to