Quoting r. Or Gerlitz <[EMAIL PROTECTED]>: > Subject: Re: [PATCH] mutex-backport: add mutex_trylock support > > Michael S. Tsirkin wrote: > >Lets be explicit then, and give some actual information: > >/* NB: mutex_trylock returns 1 on success, down_trylock - 0 on success. */ > >Make sense? > > it does make sense, anyway I just brought a quote from the code of > 2.6.16/kernel/mutex.c so i dont see any reason to change it.
Please copy verbatim then: * NOTE: this function follows the spin_trylock() convention, so * it is negated to the down_trylock() return values! Be careful * about this when converting semaphore users to mutexes. Both NOTE and the last line are missing. -- Michael S. Tsirkin Staff Engineer, Mellanox Technologies _______________________________________________ openib-general mailing list [email protected] http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
