Quoting r. Roland Dreier <[EMAIL PROTECTED]>: > Subject: Re: [openib-general] Re: [PATCH 1 of 2] static rate encoding change > (kernel) > > Michael> ib_max_link_rate then? The point is that we cant force > Michael> the actual rate at which the connection works, but we can > Michael> set the top limit to avoid back-pressure along the path, > Michael> so its the maximum rate, not the actual rate. > > I don't get where the "max" is coming from for the type name. This > enum represents values of the PathRecord:Rate field, so it's just a > rate. In fact maybe enum ib_path_rate is the best name for it.
Right. > Then a consumer can take the path rate and put it in the static_rate > field of an ah_attr to control the maximum rate that packets are > injected. If anything, "static_rate" is what would make sense to > rename to "max_rate". Yes, that's my point. > In other words, the enum just holds rates. It's the > ib_ah_attr.static_rate field where the rate represents a maximum. OK. So lets call it ib_link_rate and rename ib_ah_attr.static_rate to ib_ah_attr.max_rate. Makes sense? Sean? -- Michael S. Tsirkin Staff Engineer, Mellanox Technologies _______________________________________________ openib-general mailing list [email protected] http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
