> +static int ipath_sma_release(struct inode *in, struct file *fp)
 > +{
 > +    int s;
 > +
 > +    ipath_sma_alive = 0;
 > +    ipath_cdbg(SMA, "Closing SMA device\n");
 > +    for (s = 0; s < atomic_read(&ipath_max); s++) {
 > +            struct ipath_devdata *dd = ipath_lookup(s);
 > +
 > +            if (!dd || !(dd->ipath_flags & IPATH_INITTED))
 > +                    continue;
 > +            *dd->ipath_statusp &= ~IPATH_STATUS_SMA;
 > +            if (dd->verbs_layer.l_flags & IPATH_VERBS_KERNEL_SMA)
 > +                    *dd->ipath_statusp |= IPATH_STATUS_OIB_SMA;
 > +    }
 > +    return 0;
 > +}

Similarly what protects against another process opening the device
right after the ipath_sma_alive = 0 setting, but before you do all the
cleanup that's after that?

And what protects against a hot unplug of a device after the test of s
against ipath_max?

 - R.
_______________________________________________
openib-general mailing list
[email protected]
http://openib.org/mailman/listinfo/openib-general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general

Reply via email to