On Thu, Mar 09, 2006 at 03:18:49PM -0800, Roland Dreier wrote:
Thanks for CC:ing me, but where were the originals of these posted?
> > +static ssize_t show_version(struct device_driver *dev, char *buf)
> > +{
> > + return scnprintf(buf, PAGE_SIZE, "%s", ipath_core_version);
> > +}
>
> Any reason you left a "\n" off of this attribute?
>
> > +static ssize_t show_atomic_stats(struct device_driver *dev, char *buf)
> > +{
> > + memcpy(buf, &ipath_stats, sizeof(ipath_stats));
> > +
> > + return sizeof(ipath_stats);
> > +}
>
> I think putting a whole binary struct in a sysfs attribute is
> considered a no-no.
That's an understatement, where is the large stick to thwap the author
of this code...
thanks,
greg k-h
_______________________________________________
openib-general mailing list
[email protected]
http://openib.org/mailman/listinfo/openib-general
To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
