On Tue, 2006-03-14 at 08:03 -0800, Roland Dreier wrote:

> Also I don't see much chance of having the skb queue be full but not
> having a path record query pending.
> 

        if (path->ah) {
                kref_get(&path->ah->ref);
                neigh->ah = path->ah;

                ipoib_send(dev, skb, path->ah,
                           be32_to_cpup((__be32 *) skb->dst->neighbour->ha));
        } else {
                neigh->ah  = NULL;
                if (skb_queue_len(&neigh->queue) < IPOIB_MAX_PATH_REC_QUEUE)
                        __skb_queue_tail(&neigh->queue, skb);
                else
                        goto err_list;

                if (!path->query && path_rec_start(dev, path))
                        goto err_list;
        }

The if on the skb queue len is not necessary since this queue is on a
newly created neighbor and is obviously empty. Then the path query would
be called if path->query is null.
_______________________________________________
openib-general mailing list
[email protected]
http://openib.org/mailman/listinfo/openib-general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general

Reply via email to