Steve Wise wrote:
Here is a patch that allows me to remove all the stub/ENOSYS methods
from the chelsio provider.  I tested this on the main trunk by running
ibv_rc_pingpong and rping over mthca.

Steve, what's wrong with chelsio driver providing ENOSYS stubs?

All you are doing is making the code path longer for
drivers that do provide those entry points.

grant

This patch is in response to a review comment from Roland.  He didn't
want providers to have to stub these.

I'm not even sure this is possible, but could we create an rdma_nosys() routine that takes a variable arguments and simply returns -ENOSYS, and set all unimplemented functions to reference that routine? This could be done in the core, and would avoid branches in the code paths.

- Sean
_______________________________________________
openib-general mailing list
[email protected]
http://openib.org/mailman/listinfo/openib-general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general

Reply via email to