Is cm_copy_private_data() intentionally returning NULL rather than, say something like, ERR_PTR(-EINVAL) ? The problem is that in the caller, a NULL ptr translates to success (0 > unsigned -1000), which might lead to errors in other code paths.
Though from a cursory examination, I couldn't find any specific oops cases as private_data/len seem to be checked, but the problem is that this results in freeing up earlier allocated private_data through cm_set_private_data(), while the id state is ESTABLISHED. Hence looks like a bug to me. _______________________________________________ openib-general mailing list [email protected] http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
