Quoting r. Or Gerlitz <[EMAIL PROTECTED]>: > Subject: Re: RFC: kill CFLAGS in makefiles? > > Michael S. Tsirkin wrote: > >Hi! > >I'd like to propose moving > >EXTRA_CFLAGS += -Idrivers/infiniband/include > >out of our makefiles in svn. > > > >Users already must know about include/rdma in linux tree, so > >making that a softlink to svn for development is not an issue. > > > >With the existing arrangement there are 2 places to look for for > >headers, which is not robust. > > > >Comments? > > > > Please note that this scheme helps using files added for back and future > (!) ports eg the mutex and the index things, so the trick is that having > the code doing > > #include <linux/backport.file.h> > > and the svn having a directory > > include/linux > > and > > drivers/infiniband softlinking to the svn tree > > make things to work > > Or.
Yea, that's confusing, too. We do it inside an ifdef anyway, so why not #include <rdma/backport.file.h> and be done with it? -- Michael S. Tsirkin Staff Engineer, Mellanox Technologies _______________________________________________ openib-general mailing list [email protected] http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
