Christoph Hellwig wrote:
On Thu, Mar 09, 2006 at 01:51:46PM +0200, Or Gerlitz wrote:
I have placed below a printout with some details re all the SCSI
commands issued during the ML discovery and setting of the drive, you
can see that an INQUIRY command reading 36 bytes is sent down with zero
use_sg (other zero use_sg commands don't read/write anything so there's
nothing to worry).
looks like you have a testcase for SCSI_IOCTL_SEND_COMMAND, nice.
Could you test the patch below, which should make this remaning user
of non-SG commands go away?
Cool, I have tested your patch against the official 2.6.16 and it works!
So i get (full output below, its for 2 LUNs)
> prog hwscan is using a deprecated SCSI ioctl, pls convert it to SG_IO
> itt 32 op 01 flags c1 cdb[0-3] 12 01 80 00 use_sg 1 edtl 36
That is the SCSI command related to this specific SCSI ioctl is now
provided with use_sg = 1
I am now running iser over a patched kernel with
BUG_ON(sc->sc_data_direction != DMA_NONE &&
sc->use_sg == 0)
So far with dd, sgp_dd, iozone and no BUG yet.
> md: raidstart(pid 19839) used deprecated START_ARRAY ioctl. This will
not be supported beyond July 2006
> itt 41 op 01 flags c1 cdb[0-3] 28 00 03 6a use_sg 1 edtl 4096
Using md i have caught also this SCSI ioctl but it seems to have use_sg
= 1 as well (here i dont know how it was before your patch...)
Or.
scsi2 : iSCSI Initiator over iSER, v.0.3
itt 0 op 01 flags c1 cdb[0-3] 12 00 00 00 use_sg 1 edtl 36
itt 1 op 01 flags c1 cdb[0-3] 12 00 00 00 use_sg 1 edtl 252
Vendor: DotHill Model: SANnet II FC Rev: 411I
Type: Direct-Access ANSI SCSI revision: 03
itt 2 op 01 flags 81 cdb[0-3] 00 00 00 00 use_sg 0 edtl 0
itt 3 op 01 flags c1 cdb[0-3] 25 00 00 00 use_sg 1 edtl 8
SCSI device sda: 57344000 512-byte hdwr sectors (29360 MB)
itt 4 op 01 flags c1 cdb[0-3] 1a 00 3f 00 use_sg 1 edtl 4
sda: Write Protect is off
sda: Mode Sense: 8f 00 00 08
itt 5 op 01 flags c1 cdb[0-3] 1a 00 08 00 use_sg 1 edtl 4
itt 6 op 01 flags c1 cdb[0-3] 1a 00 08 00 use_sg 1 edtl 32
SCSI device sda: drive cache: write back
itt 7 op 01 flags 81 cdb[0-3] 00 00 00 00 use_sg 0 edtl 0
itt 8 op 01 flags c1 cdb[0-3] 25 00 00 00 use_sg 1 edtl 8
SCSI device sda: 57344000 512-byte hdwr sectors (29360 MB)
itt 9 op 01 flags c1 cdb[0-3] 1a 00 3f 00 use_sg 1 edtl 4
sda: Write Protect is off
sda: Mode Sense: 8f 00 00 08
itt 10 op 01 flags c1 cdb[0-3] 1a 00 08 00 use_sg 1 edtl 4
itt 11 op 01 flags c1 cdb[0-3] 1a 00 08 00 use_sg 1 edtl 32
SCSI device sda: drive cache: write back
sda:<3>itt 12 op 01 flags c1 cdb[0-3] 28 00 00 00 use_sg 1 edtl 4096
unknown partition table
sd 2:0:0:0: Attached scsi disk sda
sd 2:0:0:0: Attached scsi generic sg0 type 0
itt 13 op 01 flags c1 cdb[0-3] a0 00 00 00 use_sg 1 edtl 4096
itt 14 op 01 flags c1 cdb[0-3] 12 20 00 00 use_sg 1 edtl 36
itt 15 op 01 flags c1 cdb[0-3] 12 20 00 00 use_sg 1 edtl 252
Vendor: DotHill Model: SANnet II FC Rev: 411I
Type: Direct-Access ANSI SCSI revision: 03
itt 16 op 01 flags 81 cdb[0-3] 00 00 00 00 use_sg 0 edtl 0
itt 17 op 01 flags c1 cdb[0-3] 25 00 00 00 use_sg 1 edtl 8
SCSI device sdb: 57344000 512-byte hdwr sectors (29360 MB)
itt 18 op 01 flags c1 cdb[0-3] 1a 00 3f 00 use_sg 1 edtl 4
sdb: Write Protect is off
sdb: Mode Sense: 8f 00 00 08
itt 19 op 01 flags c1 cdb[0-3] 1a 00 08 00 use_sg 1 edtl 4
itt 20 op 01 flags c1 cdb[0-3] 1a 00 08 00 use_sg 1 edtl 32
SCSI device sdb: drive cache: write back
itt 21 op 01 flags 81 cdb[0-3] 00 00 00 00 use_sg 0 edtl 0
itt 22 op 01 flags c1 cdb[0-3] 25 00 00 00 use_sg 1 edtl 8
SCSI device sdb: 57344000 512-byte hdwr sectors (29360 MB)
itt 23 op 01 flags c1 cdb[0-3] 1a 00 3f 00 use_sg 1 edtl 4
sdb: Write Protect is off
sdb: Mode Sense: 8f 00 00 08
itt 24 op 01 flags c1 cdb[0-3] 1a 00 08 00 use_sg 1 edtl 4
itt 25 op 01 flags c1 cdb[0-3] 1a 00 08 00 use_sg 1 edtl 32
SCSI device sdb: drive cache: write back
sdb:<3>itt 26 op 01 flags c1 cdb[0-3] 28 00 00 00 use_sg 1 edtl 4096
unknown partition table
sd 2:0:0:1: Attached scsi disk sdb
sd 2:0:0:1: Attached scsi generic sg1 type 0
itt 27 op 01 flags c1 cdb[0-3] 12 01 00 00 use_sg 1 edtl 254
itt 28 op 01 flags c1 cdb[0-3] 12 01 83 00 use_sg 1 edtl 254
itt 29 op 01 flags c1 cdb[0-3] 12 01 00 00 use_sg 1 edtl 254
itt 30 op 01 flags c1 cdb[0-3] 12 01 83 00 use_sg 1 edtl 254
itt 31 op 01 flags c1 cdb[0-3] 28 00 00 00 use_sg 1 edtl 4096
program hwscan is using a deprecated SCSI ioctl, please convert it to SG_IO
itt 32 op 01 flags c1 cdb[0-3] 12 01 80 00 use_sg 1 edtl 36
itt 33 op 01 flags c1 cdb[0-3] 28 00 00 00 use_sg 8 edtl 32768
itt 34 op 01 flags c1 cdb[0-3] 28 00 00 00 use_sg 1 edtl 4096
itt 35 op 01 flags c1 cdb[0-3] 28 00 00 00 use_sg 7 edtl 28672
itt 36 op 01 flags c1 cdb[0-3] 28 00 00 00 use_sg 1 edtl 4096
program hwscan is using a deprecated SCSI ioctl, please convert it to SG_IO
itt 37 op 01 flags c1 cdb[0-3] 12 01 80 00 use_sg 1 edtl 36
itt 38 op 01 flags c1 cdb[0-3] 28 00 00 00 use_sg 8 edtl 32768
itt 39 op 01 flags c1 cdb[0-3] 28 00 00 00 use_sg 1 edtl 4096
itt 40 op 01 flags c1 cdb[0-3] 28 00 00 00 use_sg 7 edtl 28672
md: raidstart(pid 19839) used deprecated START_ARRAY ioctl. This will
not be supported beyond July 2006
itt 41 op 01 flags c1 cdb[0-3] 28 00 03 6a use_sg 1 edtl 4096
_______________________________________________
openib-general mailing list
[email protected]
http://openib.org/mailman/listinfo/openib-general
To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
