On Thu, 2006-03-23 at 14:21, Sasha Khapyorsky wrote: > On 13:16 Thu 23 Mar , Hal Rosenstock wrote: > > > > > > > The realizability is when the port joins not when the group is created. > > > > This is significant for the precreated groups (as other groups are > > > > created when the first port joins). > > > > > > > > Is min rate/MTU needed for anything ? > > > > > > Currently it is used when the rate is not requested. > > > > for what ? > > As rate value for created MC group.
Is this really the right thing to be doing ? What are the cases where MTU or rate are not supplied at group creation time ? > > > Also for cases when the rate is requested as greater than specified value. > > > There is such check: if (rate_requested >= min_ca_rate) error... - the > > > same problem I think. > > > > So disregard what ? > > min_ca_rate value as failure criteria. There may be something like: > > rate = rate_requested + 1; > if (rate < min_ca_rate) > rate = min_ca_rate; > > Also in IBTA spec there is option RateSelector=3, when maximum available > rate are desired (the rate value specified in request is ignored). I > don't see that it is handled somehow. I think we may use port's rate > here. Same for MTU (selector 3) too. > > Part of that patch is still valid, right ? > > Right, it still valid. However I will add discussed IB_MIN/MAX_RATE > range check for requested rate and reissue. > > I think the rest of issues are beyond of this patch topic and should be > handled handled in separate patch. Agreed. -- Hal > Sasha. _______________________________________________ openib-general mailing list [email protected] http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
