ib_sa_cancel_query must be called with priv->lock held since
a completion might arrive and set path->query to NULL

Signed-off-by: Eli Cohen <[EMAIL PROTECTED]>

Index: latest/drivers/infiniband/ulp/ipoib/ipoib_main.c
===================================================================
--- latest.orig/drivers/infiniband/ulp/ipoib/ipoib_main.c
+++ latest/drivers/infiniband/ulp/ipoib/ipoib_main.c
@@ -342,14 +342,16 @@ void ipoib_flush_paths(struct net_device
        list_for_each_entry(path, &remove_list, list)
                rb_erase(&path->rb_node, &priv->path_tree);
 
-       spin_unlock_irqrestore(&priv->lock, flags);
 
        list_for_each_entry_safe(path, tp, &remove_list, list) {
                if (path->query)
                        ib_sa_cancel_query(path->query_id, path->query);
+               spin_unlock_irqrestore(&priv->lock, flags);
                wait_for_completion(&path->done);
                path_free(dev, path);
+               spin_lock_irqsave(&priv->lock, flags);
        }
+       spin_unlock_irqrestore(&priv->lock, flags);
 }
 
 static void path_rec_completion(int status,
_______________________________________________
openib-general mailing list
[email protected]
http://openib.org/mailman/listinfo/openib-general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general

Reply via email to