You are right.
Without adding the event handling to IPoIB, IPoIB will not re-register
with the SM in some cases.
We really should add it.
I'll add the event handling to IPoIB a bit later.
Anyway, I think we could apply the patch.
The CLIENT_REREGISTER request was not supported by older FW, and now we
behave the same way.
In most cases, the event comes together with the PORT_ACTIVE event, so
we don't miss much here.
That's why I think that the patch doesn't harm IPoIB.
Michael S. Tsirkin wrote:
Quoting r. Leonid Arsh <[EMAIL PROTECTED]>:
Subject: Re: [openib-general][PATCH] mthca & ib_verbs.h client reregister event
support by the SW
Michael,
IPoIB used to interpret the CLIENT_REREGISTER event as a LID_CHANGE event
before. That's why we could see that sometimes that IPoIB handled the
LID_CHANGE event additional times. With the patch, IPoIB will receive the
correct CLIENT_REREGISTER event.
But it will ignore this event, won't it?
So where previously IPoIB responded to CLIENT_REREGISTER in the same way
as to LID_CHANGE and re-registered with SM, it now won't do it, which seems
wrong.
Am I missing something?
_______________________________________________
openib-general mailing list
[email protected]
http://openib.org/mailman/listinfo/openib-general
To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
