Hi Ofer,

On Wed, 2006-04-26 at 05:29, Ofer Gigi wrote:
> Hi Hal,
> Small minor chnages:

Subject is inconsistent with the patch below.

> 1. Adding () for the if statement

Those extra parentheses shouldn't be needed as && is lower precedence
than ==.
 
> 2. Clearer messages when duplicate guids are found  

Should Fatal be FATAL so it really stands out ?

I applied the second portion of this patch with some cosmetic changes to
both the trunk and 1.0 branch.

-- Hal

> Thanks
> 
> Ofer G.
> 
> Signed-off-by:  Ofer Gigi <[EMAIL PROTECTED]>


_______________________________________________
openib-general mailing list
[email protected]
http://openib.org/mailman/listinfo/openib-general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general

Reply via email to