On Thu, 27 April 2006 12:49:17 +0200, Heiko J Schick wrote:
>
> + ret = hipz_h_alloc_resource_eq(shca->ipz_hca_handle,
Indentation?
> + &eq->pf,
> + type,
> + length,
> + &eq->ipz_eq_handle,
> + &eq->length,
> + &nr_pages, &eq->ist);
> +
> + if (ret != H_SUCCESS) {
Common convention is to return 0 on success and -ESOMETHING on eror.
You might want to follow that and remove H_SUCCESS from the complete
code.
> + if (!(vpage = ipz_qpageit_get_inc(&eq->ipz_queue))) {
I personally despise assignments in conditionals. Not sure if this is
documented in CodingStyle, but IME most kernel hackers tend to dislike
it as well.
Jörn
--
Don't patch bad code, rewrite it.
-- Kernigham and Pike, according to Rusty
_______________________________________________
openib-general mailing list
[email protected]
http://openib.org/mailman/listinfo/openib-general
To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
