On Wed, May 17, 2006 at 06:40:04PM +0300, Ishai Rabinovitz wrote:
> Hi,
>
> While doing a code review I found a potential bug.
> I did not manage to execute a test to check this code.
> Please take a look:
Sorry, I made a mistake in the patch.
Please look at this one.
In srp_reconnect_target it uses req->scmnd->scsi_done(req->scmnd); (like in the
patch)
Ishai
> Signed-off-by: Ishai Rabinovitz <[EMAIL PROTECTED]>
> --------------------------------------
> Index: last_stable/drivers/infiniband/ulp/srp/ib_srp.c
> ===================================================================
> --- last_stable.orig/drivers/infiniband/ulp/srp/ib_srp.c 2006-05-17
> 16:24:24.000000000 +0300
> +++ last_stable/drivers/infiniband/ulp/srp/ib_srp.c 2006-05-17
> 17:13:47.000000000 +0300
> @@ -1326,7 +1326,7 @@ static int srp_reset_device(struct scsi_
> list_for_each_entry_safe(req, tmp, &target->req_queue, list)
> if (req->scmnd->device == scmnd->device) {
> req->scmnd->result = DID_RESET << 16;
> - scmnd->scsi_done(scmnd);
> + req->scmnd->scsi_done(req->scmnd);
> srp_remove_req(target, req);
> }
>
> --
> Ishai Rabinovitz
> _______________________________________________
> openib-general mailing list
> [email protected]
> http://openib.org/mailman/listinfo/openib-general
>
> To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
--
Ishai Rabinovitz
_______________________________________________
openib-general mailing list
[email protected]
http://openib.org/mailman/listinfo/openib-general
To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
