Thanks... one further fix for Cisco gateways: sometimes the IsDM bit
is set on switch ports as well, so ibsrpdm should not be limited to
just CA ports.

Here's the patch, also on the trunk as r7836.

--- srptools/ChangeLog  (revision 7803)
+++ srptools/ChangeLog  (working copy)
@@ -1,3 +1,10 @@
+2006-06-08  Roland Dreier  <[EMAIL PROTECTED]>
+
+       * src/srp-dm.c (get_port_list): In some setups (eg Cisco SFS 3001
+       with an FC gateway), there will be switches with the IsDM bit set
+       on port 0.  So the initial get of NodeRecords must retrieve all
+       records, not just CA ports.
+
 2006-06-07  Roland Dreier  <[EMAIL PROTECTED]>
        * src/srp-dm.c (do_port): Use correct endianness when comparing
        GUID against Topspin OUI.
--- srptools/src/srp-dm.c       (revision 7803)
+++ srptools/src/srp-dm.c       (working copy)
@@ -523,11 +523,9 @@ static int get_port_list(int fd, uint32_
        out_sa_mad->mgmt_class    = SRP_MGMT_CLASS_SA;
        out_sa_mad->method        = SRP_SA_METHOD_GET_TABLE;
        out_sa_mad->class_version = 2;
-       out_sa_mad->comp_mask     = htonll(1ul << 4); /* node type */
+       out_sa_mad->comp_mask     = 0; /* Get all end ports */
        out_sa_mad->rmpp_version  = 1;
        out_sa_mad->rmpp_type     = 1;
-       node                      = (void *) out_sa_mad->data;
-       node->type                = 1; /* CA */
 
        len = send_and_get(fd, &out_mad, in_mad, node_table_response_size);
        if (len < 0)

_______________________________________________
openib-general mailing list
[email protected]
http://openib.org/mailman/listinfo/openib-general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general

Reply via email to