Zach> Also, while looking at this I saw that the locks are being
Zach> re-initialized from mthca_modify_qp(). Is that just a
Zach> side-effect of relying on mthca_wq_init() to reset the
Zach> non-lock members? If you're concerned about
Zach> microoptimization it seems like this could be avoided.
I think that is actually a very minor bug you've found. If someone
were posting a work request at the same time as they transitioned a QP
to reset (which is a legitimate if not sensible thing to do), then the
spinlock could get reinitialized while it was held. Which would be
bad. So I think I like your original patch the best.
- R.
_______________________________________________
openib-general mailing list
[email protected]
http://openib.org/mailman/listinfo/openib-general
To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
