Michael S. Tsirkin wrote:
> Thanks for following up on this, on the surface looks good.
> I'm busy at the moment, but a quick question:
>
> Quoting r. Pradipta Kumar Banerjee <[EMAIL PROTECTED]>:
>> +static void pp_wait_for_done(struct pingpong_context *ctx)
>> +{
>> + struct ibv_wc wc;
>> + int ne;
>> +
>> + do {
>> + usleep(500);
>> + ne = ibv_poll_cq(ctx->rcq, 1, &wc);
>> + } while (ne == 0);
>
> I wander whether we can get rid of the rcq and an extra send at the
> end by simply closing the QP, and ignoring the possible completion with error
> for the last round. I think this would be a nice simplification.
> What do you think?
>
Indeed we can get rid of the extra send at the end (pp_wait_for_done and
pp_send_done can be removed). As for the rcq need to think about it. Its being
used to synchronize the client and the server so that the client sends the
first
message.
Thanks,
Pradipta Kumar.
_______________________________________________
openib-general mailing list
[email protected]
http://openib.org/mailman/listinfo/openib-general
To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
