Michael S. Tsirkin wrote:
>> ret = cm_init_av_by_path(&work->path[1], &cm_id_priv->alt_av);
>>- if (ret)
>>+ if (ret) {
>>+ cm_issue_rej(work->port, work->mad_recv_wc,
>>+ IB_CM_INVALID_ALT_GID, CM_MSG_RESPONSE_REQ,
>>+ NULL, 0);
>>+ reject = 0;
>> goto error3;
>>+ }
>> }
>
>
> Hmm ... it looks like cm_init_av_by_path can also fail if ib_find_cached_pkey
> returns an error - is it right that your patch will return invalid gid
> in this case?
>
> Maybe the right thing to do is to
> 1. Make cm_init_av_by_path return a more specific error in case of GID
> mismatch.
> ENXIO might be a good fit, but we can always add our own
> 2. Teach cm_destroy_id to send invalid gid reject on this error
I'm not sure what the correct reject message would be for an invalid pkey...
I agree that being more specific would be good though.
- Sean
_______________________________________________
openib-general mailing list
[email protected]
http://openib.org/mailman/listinfo/openib-general
To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
