Quoting r. Roland Dreier <[EMAIL PROTECTED]>:
> Subject: Re: [openib-general] 2 patches in mst-for-2.6.18
> 
>  > [PATCH] IB/ipoib: fix packet loss after hardware address update
> 
> Hm, OK I guess.  Are we sure that the memcmp in the data path is OK?

I did some measurements with netperf and did not notice any change.

>  > [PATCH] IB/mad: validate MADs for spec compliance C13-18.1.1
> 
> Seems fine but I wonder why the ib_response_mad function moved into a
> public header.

Oops, looks like I picked some wrong bits from svn.
Will redo the patch tomorrow - or try picking the patch from svn by yourself.

> Also, how does this patch do this:
> 
>  > Also verify that RMPP MADs are data only, to avoid a userspace
>  > app causing a kernel crash by sending non-data MADs.
> 
> what is the crash?  And how does adding a check for the BM class fix this?

I'll let Sean address these.

-- 
MST

_______________________________________________
openib-general mailing list
[email protected]
http://openib.org/mailman/listinfo/openib-general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general

Reply via email to