Quoting r. Arjan van de Ven <[EMAIL PROTECTED]>: > Subject: Re: [PATCH] lockdep: don't pull in includes when lockdep disabled > > On Wed, 2006-07-26 at 09:26 +0300, Michael S. Tsirkin wrote: > > Ingo, does the following look good to you? > > > > Do not pull in various includes through lockdep.h if lockdep is disabled. > > Hi, > > can you tell us what this fixes? Eg is there a specific problem?
Er ... it's a cosmetic change - there's no serious problem, it is just that even if I disable lockdep, linux/lockdep.h will pull in several headers even though they are not needed -> more useless work for compiler to do. > I mean... we're adding ifdefs Note this doesn't add ifdefs, just moves them around. > so there better be a real good reason for > them.... fixing something real would be such a reason ;-) Well, I don't expect this specific bit to speed compilation up in any measurable way, but unnecessary includes do have the tendency to accumulate and lead to slower builds ... Is that a reason? -- MST _______________________________________________ openib-general mailing list [email protected] http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
