On Tue, Aug 01, 2006 at 04:50:18PM -0700, Roland Dreier wrote: > I guess this is pretty uncontroversial, so I'll check this in > tomorrow. Before you do it check libmthca/src/buf.c file please. It look funny at least in patch you've sent (as if somebody did cat buf.c >> buf.c)
> But one last call for comments: in particular, does anyone > object to libibverbs being fork-unsafe by default unless ibv_fork_init > is called? > I am not sure about this one. The library like MPI will have to always call this anyway. On the other side if some library calls fork() without application knowing it? Suddenly programmer should care about such details. Perhaps opt out is better the opt in and libibverbs should skip ibv_fork_init() only if application ask this explicitly? > > +/** > > + * ibv_fork_init - Prepare data structures so that fork() may be used > > + * safely. If this function is not called or returns a non-zero > > + * status, then libibverbs data structures are not fork()-safe and the > > + * effect of an application calling fork() is undefined. > > + */ > > +int ibv_fork_init(void); > > - R. > > _______________________________________________ > openib-general mailing list > [email protected] > http://openib.org/mailman/listinfo/openib-general > > To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general -- Gleb. _______________________________________________ openib-general mailing list [email protected] http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
