Hi Yevgeny,

On Sun, 2006-08-27 at 10:49, Yevgeny Kliteynik wrote:
> Hi Hal.
> 
> This is a resubmission of the patch that addresses 
> the comments that I got on the first version - using 
> osm-log.conf file instead of opensmlog.conf and osm 
> man page update.

Thanks.

Would you rebase this off the latest trunk (and revalidate) ? A number
of the patches were rejected and it is too much to do by hand. There
were some recent changes in the osm_log area that affect this patch.

Also, see a couple of comments embedded below.

-- Hal

> Yevgeny
> 
> Signed-off-by:  Yevgeny Kliteynik <[EMAIL PROTECTED]>

[snip...]

> Index: opensm/libopensm.map
> ===================================================================
> --- opensm/libopensm.map      (revision 9107)
> +++ opensm/libopensm.map      (working copy)
> @@ -1,6 +1,11 @@
> -OPENSM_1.1 {
> +OPENSM_2.0 {

Does libopensm.ver need changing too ?

>       global:
> -             osm_log;
> +             osm_log_init_ext;
> +             osm_log_ext;
> +             osm_log_raw_ext;
> +             osm_log_get_level_ext;
> +             osm_log_is_active_ext;
> +             osm_log_read_verbosity_file;
>               osm_is_debug;
>               osm_mad_pool_construct;
>               osm_mad_pool_destroy;
> @@ -39,7 +44,6 @@ OPENSM_1.1 {
>               osm_dump_dr_path;
>               osm_dump_smp_dr_path;
>               osm_dump_pkey_block;
> -             osm_log_raw;
>               osm_get_sm_state_str;
>               osm_get_sm_signal_str;
>               osm_get_disp_msg_str;
> @@ -51,5 +55,11 @@ OPENSM_1.1 {
>               osm_get_lsa_str;
>               osm_get_sm_mgr_signal_str;
>               osm_get_sm_mgr_state_str;
> +             st_init_strtable;
> +             st_delete;
> +             st_insert;
> +             st_lookup;
> +             st_foreach;
> +             st_free_table;

Should the other st_ routines also be added ?

st_init_table_with_size
st_init_numtable
st_init_numtable_with_size
st_init_strtable_with_size
st_add_direct
st_copy
st_delete_safe
st_cleanup_safe

>       local: *;
>  };

[snip...]


_______________________________________________
openib-general mailing list
[email protected]
http://openib.org/mailman/listinfo/openib-general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general

Reply via email to